Support reading a file to pyarrow table in catalog import #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #415 +/- ##
==========================================
- Coverage 99.00% 98.88% -0.13%
==========================================
Files 29 29
Lines 1609 1612 +3
==========================================
+ Hits 1593 1594 +1
- Misses 16 18 +2 ☔ View full report in Codecov by Sentry. |
smcguire-cmu
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This is related to issue #351, but does not close it.
Allows the InputReader read method to return a pyarrow Table, instead of a Pandas dataframe. Pandas dataframes are converted to pyarrow tables, and all manipulation after that point is based on pyarrow operations.
This means that tables generated will NOT have the
_healpix_29field set as the pandas index.